8000 Fix release by madhur-tandon · Pull Request #152 · pyscript/pyscript-cli · GitHub
[go: up one dir, main page]
Skip to content

Fix release #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up f 8000 or GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 26, 2024
+137 −117
Merged

Fix release #152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4314980
version gatekeep while releasing
madhur-tandon Aug 26, 2024
fe5bd0a
version gatekeep while releasing
madhur-tandon Aug 26, 2024
a9422ad
linting
madhur-tandon Aug 26, 2024
459f543
fix linting
madhur-tandon Aug 26, 2024
6018a95
add check_version env
madhur-tandon Aug 26, 2024
f59d141
linting
madhur-tandon Aug 26, 2024
3402bf7
fix jinja stuff
madhur-tandon Aug 26, 2024
1f18d95
linting
madhur-tandon Aug 26, 2024
a925409
fix linting again
madhur-tandon Aug 26, 2024
d0a6a03
include version file
madhur-tandon Aug 26, 2024
92c8b0a
add zip_safe as False
madhur-tandon Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add check_version env
  • Loading branch information
@madhur-tandon
madhur-tandon committed Aug 26, 2024
commit 6018a9545716dbbaebdf2a0cebeffa6c59d7278f
5 changes: 2 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ jobs:
with:
python-version: 3.11

- name: Install dependencies
run: pip install -r requirements.txt

- name: Build and package
env:
CHECK_VERSION: "true"
run: |
pip install wheel
python setup.py sdist bdist_wheel
Expand Down
13 changes: 7 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ def read_version():


def check_tag_version():
tag = os.getenv("GITHUB_REF")
expected_version = read_version()
if tag != f"refs/tags/{expected_version}":
raise Exception(
f"Tag '{tag}' does not match the expected " f"version '{expected_version}'"
)
if os.getenv("CHECK_VERSION", "false").lower() == "true":
tag = os.getenv("GITHUB_REF")
expected_version = read_version()
if tag != f"refs/tags/{expected_version}":
raise Exception(
f"Tag '{tag}' does not match the expected " f"version '{expected_version}'"
)


with open("README.md") as fh:
Expand Down
Loading
0