8000 Refactor py-config and the general initialization logic of the page by antocuni · Pull Request #806 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Refactor py-config and the general initialization logic of the page #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antocuni merged 34 commits into from
Oct 4, 2022
Merged

Refactor py-config and the general initialization logic of the page #806

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
77be53a
start to remove module-level statements, and put all the logic in its…
antocuni Sep 29, 2022
a1124da
add a JS API to get the pyscript config and two integration tests to …
antocuni Sep 29, 2022
894a1c7
rename this file
antocuni Sep 29, 2022
4bc4029
introduce the class PyScriptApp, so have a global singleton where to …
antocuni Sep 29, 2022
5798923
small refactoring of pyconfig.ts, in preparation to make py-config NO…
antocuni Sep 29, 2022
1faeb3b
improve logging
antocuni Sep 29, 2022
6479860
start moving all the config logic to config.ts
antocuni Sep 29, 2022
540b129
move all the config logic from utils.ts into config.ts
antocuni Sep 29, 2022
62ddb90
WIP: start to refactor pyconfig.test.ts to test directly loadConfigFr…
antocuni Sep 29, 2022
634be61
WIP: allow to call loadConfigFromElement(null)
antocuni Sep 30, 2022
6ca9be5
WIP: more progress in porting tests, create a brand new element inste…
antocuni Sep 30, 2022
798c436
fix typos :)
antocuni Sep 30, 2022
ef79c64
WIP: one more test
antocuni Sep 30, 2022
257c1e9
WIP: more tests
antocuni Sep 30, 2022
07a4548
WIP: more tests
antocuni Sep 30, 2022
4789705
move the last tests to PyConfig
antocuni Sep 30, 2022
46c8aab
another small step: PyConfig is no longer a web component but it's ma…
antocuni Sep 30, 2022
c6123f3
Merge branch 'main' of github.com:pyscript/pyscript into main
antocuni Sep 30, 2022
2a185af
fix tests which were broken after the merge
antocuni Sep 30, 2022
c51621a
use JSON.stringify to get a human-readable version of the config
antocuni Sep 30, 2022
2964124
add an integration test for <py-config>paths=...
antocuni Sep 30, 2022
fe702ce
add a test for <py-config>packages...
antocuni Sep 30, 2022
35a8201
move the loadPackages logic from pyconfig into main.ts
antocuni Sep 30, 2022
d4a3138
move the loadPaths logic from pyconfig into main.ts
antocuni Sep 30, 2022
6ee7794
move the loadRuntimes() logic into main.ts
antocuni Sep 30, 2022
e2ae490
kill all the remaining references to PyConfig
antocuni Sep 30, 2022
b9e77ae
finally kill pyconfig.ts
antocuni Sep 30, 2022
8f8b4b1
now that the old pyconfig.ts has gone, we can reuse its name
antocuni Sep 30, 2022
4b37b8b
wooo, kill the appConfig store: instead of using a global variable to…
antocuni Sep 30, 2022
c0577d6
Update pyscriptjs/src/pyconfig.ts
antocuni Oct 3, 2022
c65a8ba
improve this comment
antocuni Oct 3, 2022
0dca198
try to use an older version of eslint
antocuni Oct 3, 2022
b7d4b04
Merge remote-tracking branch 'origin/main' into antocuni/refactor-py-…
antocuni Oct 4, 2022
7239e2d
use expect().toThrow instead of it.failing()
antocuni Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests which were broken after the merge
  • Loading branch information
@antocuni
antocuni committed Sep 30, 2022
commit 2a185af2abd95985fe876b6b227d3046127f197d
2 changes: 1 addition & 1 deletion pyscriptjs/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const allKeys = {
"array": ["runtimes", "packages", "paths", "plugins"]
};

const defaultConfig: AppConfig = {
export const defaultConfig: AppConfig = {
"schema_version": 1,
"type": "app",
"autoclose_loader": true,
Expand Down
32 changes: 8 additions & 24 deletions pyscriptjs/tests/unit/pyconfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ describe('loadConfigFromElement', () => {
const config = loadConfigFromElement(el);
expect(config.runtimes[0].lang).toBe('covfefe');
expect(config.pyscript?.time).not.toBeNull();
// version wasn't present in `inline config` but is still set due to merging with default
expect(config.version).toBe('0.1');
// schema_version wasn't present in `inline config` but is still set due to merging with default
expect(config.schema_version).toBe(1);
});

it('should load the JSON config from src attribute', () => {
Expand All @@ -88,8 +88,8 @@ describe('loadConfigFromElement', () => {
expect(config.pyscript?.time).not.toBeNull();
// wonderful is an extra key supplied by the user and is unaffected by merging process
expect(config.wonderful).toBe('disgrace');
// version wasn't present in `config from src` but is still set due to merging with default
expect(config.version).toBe('0.1');
// schema_version wasn't present in `config from src` but is still set due to merging with default
expect(config.schema_version).toBe(1);
});


Expand All @@ -115,8 +115,8 @@ describe('loadConfigFromElement', () => {
const config = loadConfigFromElement(el);
expect(config.runtimes[0].lang).toBe('covfefe');
expect(config.pyscript?.time).not.toBeNull();
// version wasn't present in `inline config` but is still set due to merging with default
expect(config.version).toBe('0.1');
// schema_version wasn't present in `inline config` but is still set due to merging with default
expect(config.schema_version).toBe(1);
expect(config.wonderful).toBe('hijacked');
});

Expand Down Expand Up @@ -150,13 +150,13 @@ describe('loadConfigFromElement', () => {
// somewhere else

import { PyConfig } from '../../src/components/pyconfig';
customElements.define('py-config', PyConfig);
//customElements.define('py-config', PyConfig);

describe('PyConfig', () => {
let instance: PyConfig;

beforeEach(() => {
instance = new PyConfig();
instance = new PyConfig({});
});

it('should get the Config to just instantiate', async () => {
Expand All @@ -178,16 +178,6 @@ describe('PyConfig', () => {
expect(mockedMethod).toHaveBeenCalled();
});

it('confirm connectedCallback happy path', async () => {
const mockedMethod = jest.fn();
instance.loadRuntimes = mockedMethod;
instance.innerHTML = 'test';

instance.connectedCallback();

expect(instance.values['0']).toBe('test');
});

it('log should add new message to the page', async () => {
// details are undefined, so let's create a div for it
instance.details = document.createElement('div');
Expand All @@ -196,10 +186,4 @@ describe('PyConfig', () => {
// @ts-ignore: typescript complains about accessing innerText
expect(instance.details.childNodes[0].innerText).toBe('this is a log');
});

it('confirm that calling close would call this.remove', async () => {
instance.remove = jest.fn();
instance.close();
expect(instance.remove).toHaveBeenCalled();
});
})
0