README and getting started updates #72
Conversation
|
on my no too old installation: |
|
@msaroufim thank you so much for the PR! It's conflicting with the latest changes added in the meantime. Do you mind merging main and fixing the conflicts? |
|
@fpliger done! Thank you for the quick review |
GETTING-STARTED.md
Outdated
| </py-env> | ||
| ``` | ||
|
|
||
| If your `.whl` is not a pure Python wheel then open a PR or issue with [pyodide](https://github.com/pyodide/pyodide) to get it added here https://github.com/pyodide/pyodide/tree/main/packages |
There was a problem hiding this comment.
Yes, that's OK. We are trying to make this easier but for now, that's indeed what one has to do.
There was a problem hiding this comment.
Opening a PR or issue on the Pyodide issue tracker is good advice. It might be worth commenting that if there is popular demand from 3+ different users the Pyodide team is likely to work on porting the package, if we haven't received that much interest yet you will have to write your own PR. In any case, things will be faster if you work on a PR. We like to collaborate with newcomers on ports (we may provide advice, help you if you get stuck, and or step in and work on it ourselves if it turns out it's hard in an interesting way).
Our build system has improved quite a lot but there are still a few warts that need to be ironed out. The biggest thing is sysconfig, but cross builds are hard and distutils does not support them well.
We are also working towards out of tree builds but unfortunately they aren't ready yet.
There was a problem hiding this comment.
Just clarified the language in the PR. @fpliger this should be ready to merge now
Thank you for such an amazing library, made some minor fixes after going through the library today to clarify