add release.yml, release automation ready for prod #539
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
lgtm (thanks @pww217 !!! 👍 ) but, want to ask it out loud to avoid misunderstanding...
@pww217 this does will not publish a new release to /alpha but, rather, will publish to \latest and to \<the-new-released-version-tag>, so we don't break alpha and it's frozen forever. Right? ( think most of that was also in #512 )
.github/workflows/build-release.yml
Outdated
| @@ -3,7 +3,7 @@ name: '[CI] Build Release' | |||
| on: | |||
| push: | |||
| tags: | |||
| - '[0-9][0-9][0-9][0-9].[0-9][0-9].[0-9]' | |||
| - '[0-9][0-9][0-9][0-9].[0-9][0-9].[0-9]+' | |||
There was a problem hiding this comment.
Just leaving the comment for posterity.. As agreed in previous discussions, this complies with the chosen format YYYY.MM.MICRO, where MICRO is a counter.
There was a problem hiding this comment.
Yeah, it's basically a glob pattern match that requires a valid 4 digit year, 2 digit month, and the last one should be able to go up to 99.
I made the example releases 2022.06.1 (not sure if micro starts at 1 or 0).
|
@fpliger This PR changes it to overwrite /alpha along with creating the the versioned folder. I moved the current alpha into a folder called /2022.05.1 manually. If something is broken we can basically copy that folder back to /alpha, if that makes sense. The testing should prevent it syncing a broken build but of course there's always a small risk it doesn't catch everything. |
|
If we want to test manually we should test out /unstable and if happy with that, tag that commit with a calver and have it built into an alpha. /unstable will track every commit to main that alters a file in pyscriptjs/** The reason for path filtering is because everything outside of pyscriptjs/** is linting, docs, or examples. Examples sync separately. |
|
I thought the decision was to:
Which plays nicely with the current state of things since somehow we managed to not break peoples code in |
Co-authored-by: Antonio Cuni <anto.cuni@gmail.com>
|
@fpliger with this latest commit I removed the overwriting of /alpha/ so now it will just create the versioned folder. I also changed the name of pyscript.net/unstable/ to /latest/ So in summary:
Is that correct? That was my understanding. I also committed @antocuni's calver comment. |
That's awesome @pww217 ! I think the only point that is not entirely matching is
/alpha/YYYY.MM.V/will be created on published releases per the process above
The original proposal was pyscript.net/22.06.1/ but can also be another level deep, like pyscript.net/releases/22.06.1/ or something like that. The reason I'm not super keen on /alpha/YYYY.MM.V/ is that it mixes with alpha and we'll have to rethink/change when we are getting out of alpha..
|
Alright made the alpha -> releases change and moved the files there. So here's the final summary:
|
Adds release template, adds testing back, allows for overwriting of "latest" alpha at pyscript.net/alpha/**