Move tests, create makefile action to run tests on examples #433
Conversation
|
FYI small changes to makefile and such in #418, would probably merge in main. |
|
@marimeireles is this one ready for review? |
|
This is on a forked branch so I can't edit it too easily, but @marimeireles if you could integrate some of the extra changes from #435 into this I'd appreciate it. Tag me for review when you can. |
|
@pww217 I'll look into it right now :) |
83377c3 to
0c08e44
Compare
0c08e44 to
a710d4d
Compare
a710d4d to
3edd5a4
Compare
|
Some points:
So I ask myself if we should just remove the the
|
bf87188 to
80636a2
Compare
|
Not sure I fully understand. You basically mean you're integrating the build process into your examples testing? So long as the build artifact exists and is ready to be shipped, we can do it in whatever order we want. I think for clarity I'd rather see these separated out into distinct make commands, but put in a logic order. So it seems like we're want it to look like this: make example Then assuming the build itself is still where it usually is at examples/build/pyscript.js, etc. we can copy it to S3 as a deployment. Does that make sense? |
|
The failing tests may have to do with the fact that we lose some files by moving the examples dir, but I'm not sure why we lose them. |
I thought I saw it failing on other PRs too, but no. And I see what you mean, I agree. Will change. |
|
On the question about removing build from CI. I think it's fine to say that we have to build it locally to test locally and CI can do the same. It actually ensures that the build works in different achitectures. |
…ipt into marimeireles/infra-ex
…ipt into marimeireles/infra-ex
This allows tests to run on a
examplesdirectory created just for this end.The examples created by the
make examplescommand have their path to pyscript dependencies altered so they can run with the local build.I ran the test and they all failed to me in the 2nd step:
I wonder if I'm doing something wrong... Or if they're just not working?
If they should be working locally I'll look into what's up with them tomorrow!