8000 Add testing to CI flow by pww217 · Pull Request #418 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Add testing to CI flow #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 20, 2022
Merged

Add testing to CI flow #418

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e45fcc6
new testing ci flow
pww217 May 18, 2022
7bbed10
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 18, 2022
ccd17db
install conda
pww217 May 18, 2022
91e550f
Merge branch 'add-testing-to-ci' of github.com:anaconda/pyscript into…
pww217 May 18, 2022
e5b8b07
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 18, 2022
d008dbb
test conda
pww217 May 18, 2022
c251baf
merge
pww217 May 18, 2022
b828998
pre-commit fix
pww217 May 18, 2022
aa5c407
remove if
pww217 May 18, 2022
9ec2c04
makefile fix
pww217 May 18, 2022
0cfb269
fix pytest install
pww217 May 18, 2022
db9be02
argument for test
pww217 May 18, 2022
4aecb47
restructure
pww217 May 18, 2022
23c692b
fix sync
pww217 May 18, 2022
c8dfe75
full path filter
pww217 May 18, 2022
15d8b37
use setup-condav2
pww217 May 19, 2022
f19ce3a
syntax
pww217 May 19, 2022
e79418f
test path
pww217 May 19, 2022
834e6e5
add binary argument
pww217 May 19, 2022
8000
7cace13
remove which
pww217 May 19, 2022
07033ea
Merge remote-tracking branch 'origin/main' into add-testing-to-ci
pww217 May 19, 2022
55d2f34
Update Makefile
pww217 May 19, 2022
a5715cb
remove arguments
pww217 May 19, 2022
a5e82e3
Merge remote-tracking branch 'origin/main' into add-testing-to-ci
pww217 May 20, 2022
04ba22d
trigger CI
pww217 May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Makefile
  • Loading branch information
@pww217
pww217 authored May 19, 2022
commit 55d2f340393386fac24bc66ef53ee75bc73b8c8f
1 change: 1 addition & 0 deletions pyscriptjs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ src_dir ?= $(base_dir)/src
examples ?= $(base_dir)/examples
app_dir ?= $(shell git rev-parse --show-prefix)

CONDA_EXE := conda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jezdez do you have any opinions about this? Is that fine from a pure conda perspective?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, it's basically just conda from PATH as the setup-conda action allows, but this variable existed in the makefile previously and was undefined.

CONDA_ENV ?= ./env
env := $(CONDA_ENV)
conda_run := $(CONDA_EXE) run -p $(env)
Expand Down
0