10000 fixed the bug std-err attribute cannot set stderr elements properly by hoge1e3 · Pull Request #371 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

fixed the bug std-err attribute cannot set stderr elements properly #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

fixed the bug std-err attribute cannot set stderr elements properly #371

merged 1 commit into from
May 17, 2022

Conversation

hoge1e3
Copy link
Contributor
@hoge1e3 hoge1e3 commented May 14, 2022

original version shows the error at #stdout element, not #stderr

    <h2>stdout</h2>
    <pre id="stdout"></pre>
    <h2>stderr</h2>
    <pre id="stderr"></pre>
    <py-script std-out="stdout" std-err="stderr">
error.is.occurred()
    </py-script>

fpliger
fpliger approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor
@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks @hoge1e3 !

@fpliger fpliger merged commit eb3a31a into pyscript:main May 17, 2022
@fpliger fpliger added the tag: component Related to PyScript components label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

Assignees
No one assigned
Labels
tag: component Related to PyScript components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoge1e3 @fpliger
0