8000 support different pyodide versions by fpliger · Pull Request #328 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

support different pyodide versions #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 11, 2022
Merged

support different pyodide versions #328

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2dde43e
add PyLoader class
fpliger May 6, 2022
5266c99
create global loader during app creation time and remove it when pysc…
fpliger May 6, 2022
a8e00c7
make the loader global and open/close when apps is starting. Also add…
fpliger May 7, 2022
25da2ea
add pyconfig file
fpliger May 7, 2022
271024a
auto add global config if there's no config set in the page
fpliger May 7, 2022
48fed33
export initializer type
fpliger May 10, 2022
e5e6b74
define type for config
fpliger May 10, 2022
b03e7a9
move initialization out of svelte file, into app config
fpliger May 10, 2022
d31392d
Merge branch 'main' into fpliger/172_support_different_pyodide_versions
fpliger May 11, 2022
a3771ea
change runtimes from strings to objects
fpliger May 11, 2022
c4a25a1
fix typo
fpliger May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change runtimes from strings to objects
  • Loading branch information
@fpliger
fpliger committed May 11, 2022
commit a3771ea0bc5fb7822174747e2c89eb825ed3556c
5 changes: 4 additions & 1 deletion pyscriptjs/examples/simple_clock.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
<py-config>
8000 Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this pattern

- autoclose_loader: false
- runtimes:
- "https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js"
-
src: "https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js"
name: pyodide-0.20
lang: python
</py-config>
</head>

Expand Down
20 changes: 15 additions & 5 deletions pyscriptjs/src/components/pyconfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,24 @@ import { loadInterpreter } from '../interpreter';
import type { PyScript } from './pyscript';


const DEFAULT_RUNTIME = "https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js";
const DEFAULT_RUNTIME = {
src: "https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js",
name: "pyodide-default",
lang: "python"
}

export type Runtime = {
src: string;
name?: string;
lang?: string;
};

export type AppConfig = {
autoclose_loader: boolean;
name?: string;
version?: string;
runtimes?: Array<string>;
};
runtimes?: Array<Runtime>;
};

let appConfig_: AppConfig = {
autoclose_loader: true,
Expand Down Expand Up @@ -169,8 +179,8 @@ export class PyConfig extends BaseEvalElement {
console.log("Initializing runetimes...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? runetimes

for (const runtime of this.values.runtimes) {
const script = document.createElement("script"); // create a script DOM node
const runtimeSpec = new PyodideRuntime(runtime);
script.src = runtime; // set its src to the provided URL
const runtimeSpec = new PyodideRuntime(runtime.src);
script.src = runtime.src; // set its src to the provided URL
script.onload = () => {
runtimeSpec.initialize();
}
Expand Down
0