fix ci issues #312
Merged
fix ci issues #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on moving examples to the root directory. They are distinct from the |
|
@mattkram Alright let's get this one merged in so that CI is fixed for other PRs and merges. We'll tackle the examples thing in another PR. It's not a big deal in this context - just means we'll build some redundant artifacts for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with AWS Sync and CI
For whatever reason, the build artifacts end up in pyscriptjs/examples/build/, so that's where I sync them from for now. I named the workflow
latestbut it's the same as unstable.One unideal behavior is that it will build a new
latestversion when examples change, because I can't filter forpathsandpaths-ignorein the same workflow. We may want to consider movingexamplesto the root directory instead of tucking them with the pyscriptjs files. I think the idea was to putdocsin the root too.The example sync does just that when files in that directory change, but will delete files too if they no longer exist in the repo. I had to remove a symlink in the toga/static example. I PM'd @freakboy3742 about it but I assume it was meant to be .gitignore'd. It was causing issues with the S3 syncing because it didn't understand what to do with a symlink.