Split build jobs, add S3 push #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bb647b to
d3b398e
Compare
for more information, see https://pre-commit.ci
2dc1616 to
d53d88e
Compare
|
Alright gonna merge and make sure these all work 🤞🏼 It's not the live site right now so no harm if things go awry. |
KOSIDOCS
pushed a commit
to KOSIDOCS/pyscript
that referenced
this pull request
May 10, 2022
* split files, add s3 push * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * dedent * indent * alpha directory * remove on: PR from alpha * workflow names * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove js-lint.yml (replaced by pre-commit); add sync-examples.yml * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update sync-examples.yml * change unstable to latest, master -> main Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits build jobs into
unstable- tracks main branch, tests all code on PR in pyscriptjs/and
alpha- which deploys a tagged/release build (convention tbd).It also adds a step to configure AWS credentials (limited in scope to modify S3 bucket only) and push to the appropriate keys on that bucket. This uses an IAM role not full credentials to ensure that the runner (which is owned by Github) only has limited and temporary (short-lived token-based) access to AWS.
Anything that has to do with AWS auth is obscured or handled on the backend. I don't expect there should be any security concerns here. I designed it to be as secure as possible, but please do point out any flaws.
Updated: Last commit attempted to fix version pinning. Will test again.