8000 GitHub Actions: Test on current Node.js by cclauss · Pull Request #282 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

GitHub Actions: Test on current Node.js #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

GitHub Actions: Test on current Node.js #282

merged 3 commits into from
May 9, 2022

Conversation

cclauss
Copy link
Contributor
@cclauss cclauss commented May 8, 2022

Node.js 12 is end-of-life. https://nodejs.org/en/about/releases

@pww217 pww217 added the tag: tooling Related to the configuration of infrastructure and tooling label May 9, 2022
pww217
pww217 approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor
@pww217 pww217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for me, thank you! Waiting on some of the devs who work more closely with the node stuff to give the go-ahead.

fpliger
fpliger approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor
@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @cclauss !

@pww217 pww217 merged commit 92fce06 into pyscript:main May 9, 2022
@cclauss cclauss deleted the patch-1 branch May 9, 2022 18:46
KOSIDOCS pushed a commit to KOSIDOCS/pyscript that referenced this pull request May 10, 2022
@cclauss @pww217 @KOSIDOCS
GitHub Actions: Test on current Node.js (pyscript#282)
ee66e13 
* GitHub Actions: Test on current Node.js

Node.js 12 is end-of-life.  https://nodejs.org/en/about/releases

* GitHub Actions: Test on current Node.js

* Removed outdated comment

Co-authored-by: Peter W <34256109+pww217@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

@pww217 pww217 pww217 approved these changes

Assignees
No one assigned
Labels
tag: tooling Related to the configuration of infrastructure and tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @fpliger @pww217
0