8000 Add `pre-commit` config for `eslint` by mattkram · Pull Request #259 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Add pre-commit config for eslint #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 9, 2022
Merged

Add pre-commit config for eslint #259

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
10e0ed5
Add eslint config
mattkram May 6, 2022
c398da3
Add typescript dependency
mattkram May 6, 2022
cfbcea1
Add eslint dependency
mattkram May 6, 2022
cec87e9
Disable workflows for efficiency while debugging
mattkram May 6, 2022
7d52d24
Add eslint-plugin dependency
mattkram May 6, 2022
2589b80
Add pacakge namespace
mattkram May 6, 2022
ac14a86
Add eslint-plugin-svelte3 dependency
mattkram May 6, 2022
475f76b
Add additional eslint dependencies
mattkram May 6, 2022
be35778
TEMPORARY: comment out line that breaks eslint in pre-commit
mattkram May 6, 2022
e54663b
Try to add some local path changes
mattkram May 6, 2022
2061c98
Comment out path specs
mattkram May 6, 2022
0affc8d
Restore tsconfig.json
mattkram May 6, 2022
71aa341
Fix path of files so we don't lint the examples
mattkram May 7, 2022
780ad9e
Replace extends with contents
mattkram May 7, 2022
50fd833
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 7, 2022
e60b486
Revert "Disable workflows for efficiency while debugging"
mattkram May 7, 2022
3fa46fa
Merge remote-tracking branch 'origin/mattkram/eslint-pre-commit' into…
mattkram May 7, 2022
ee134f8
Remove unneeded commented dependency
mattkram May 7, 2022
5fc3cdc
Remove extra newline
mattkram May 7, 2022
ec3a79d
Remove lines which were added but are likely not necessary
mattkram May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace extends with contents 
When running pre-commit, we cannot resolve the import
  • Loading branch information
@mattkram
mattkram committed May 7, 2022
commit 780ad9e1891e7a0104c992c136757234307725f0
10 changes: 9 additions & 1 deletion pyscriptjs/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"extends": "@tsconfig/svelte/tsconfig.json",
"$schema": "https://json.schemastore.org/tsconfig",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to replace this with values which were taken from the source npm package: https://www.npmjs.com/package/@tsconfig/svelte

This is because, while the import could be found locally when packages were installed in node_modules, it could not be found while pre-commit was running.

"display": "Svelte",
"_version": "3.0.0",

"include": ["src/**/*"],
"exclude": ["node_modules/*", "__sapper__/*", "public/*"],
Expand All @@ -21,6 +23,12 @@
/** Requests the runtime types from the svelte modules by default. Needed for TS files or else you get errors. */
"types": ["svelte"],

/**
TypeScript doesn't know about import usages in the template because it only sees the
script of a Svelte file. Therefore preserve all value imports. Requires TS 4.5 or higher.
*/
"preserveValueImports": true,

"strict": false,
"esModuleInterop": true,
"skipLibCheck": true,
Expand Down
0