10000 Add issue templates by antocuni · Pull Request #252 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content

Add issue templates #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022
Merged

Add issue templates #252

merged 2 commits into from
May 6, 2022

Conversation

antocuni
Copy link
Contributor
@antocuni antocuni commented May 6, 2022

As the name says.
This also applies the "needs-triage" label to all new issue, so that we can easily filter them.

@antocuni antocuni requested a review from philippjfr May 6, 2022 11:08
@jaynarayan-vaishnav
Copy link
Contributor

hey @antocuni ,
if I am guessing correctly then you should also look at issue #255 . I think this is related to your PR and there are more issue templates required for different categories.

@antocuni
Copy link
Contributor Author
antocuni commented May 6, 2022

yes, I wasn't aware of #255. I'll write a comment there

Copy link
Contributor
@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This will be super helpful. I'd only think we should address or discuss my comment on the wording to encourage positive feedback.

@antocuni
Copy link
Contributor Author
antocuni commented May 6, 2022

Awesome! This will be super helpful. I'd only think we should address or discuss my comment on the wording to encourage positive feedback.

done.
Note that the previous wording is the default github template for feature requests, but I agree with you that encouraging healthy discussions is helpful.

@fpliger
Copy link
Contributor
fpliger commented May 6, 2022

Ehehe.. Github, if you are listening, I'd suggest to improve this! 😆

Copy link
Contributor
@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! TY !

@fpliger fpliger merged commit ca37efb into main May 6, 2022
@fpliger fpliger deleted the antocuni/issue-template branch May 6, 2022 17:51
@fpliger fpliger added the status: accepted PR that has been reviewed and accepted label May 6, 2022
barnwell pushed a commit to barnwell/pyscript that referenced this pull request May 6, 2022
* add issue templates

* incorporate @fpliger suggestions
LtDan33 pushed a commit that referenced this pull request May 17, 2022
* add issue templates

* incorporate @fpliger suggestions
antocuni added a commit that referenced this pull request May 26, 2022
* Added bug report and feature request issue forms

* Update bug-report.yml

Added browsers dropdown to bugs

* Added misc issue type

* Add keypress event to todo example (#241)

* add enter keypress event in todo example

* fix linting

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Changed variable names to snake_case for PEP8 formatting (#211)

* Changed variable names to snakecase for PEP8 formatting.

* Changed variable names to snakecase for PEP8 formatting.

* fix indentation

Co-authored-by: Fabio Pliger <fabio.pliger@gmail.com>

* Add issue templates (#252)

* add issue templates

* incorporate @fpliger suggestions

* Removed mardown files. Added link for questions

* Updated browser dev console info

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix issue with labels that should be strings, ignore pretty-format of ISSUE_TEMPLATE yaml files

* Removed old md. Updated label

* add the needs-triage label to all new issues

Co-authored-by: Allan Lago <35788148+alago1@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jason Barnwell <master.j1994@gmail.com>
Co-authored-by: Fabio Pliger <fabio.pliger@gmail.com>
Co-authored-by: Antonio Cuni <anto.cuni@gmail.com>
Co-authored-by: Matt Kramer <mkramer@anaconda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted PR that has been reviewed and accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0