8000 Make all targets phony. by jezdez · Pull Request #249 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Make all targets phony. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2022
Merged

Make all targets phony. #249

merged 1 commit into from
May 6, 2022

Conversation

jezdez
Copy link
Member
@jezdez jezdez commented May 6, 2022

No description provided.

@jezdez jezdez requested review from fpliger and mattkram May 6, 2022 08:16
@mattkram
Copy link
Contributor
mattkram commented May 6, 2022

Whoa, TIL! I haven't run it yet so won't approve but I'll try when I'm not on my phone.

fpliger
fpliger approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor
@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding myself to the TIL list :). Thanks @jezdez !! 🚀

@fpliger fpliger merged commit 990b0b2 into main May 6, 2022
@fpliger fpliger deleted the phony-targets branch May 6, 2022 19:40
@fpliger fpliger added status: accepted PR that has been reviewed and accepted tag: tooling Related to the configuration of infrastructure and tooling labels May 6, 2022
barnwell pushed a commit to barnwell/pyscript that referenced this pull request May 6, 2022
@jezdez @barnwell
Make all targets phony. (pyscript#249)
76f1ad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

@mattkram mattkram Awaiting requested review from mattkram

Assignees
No one assigned
Labels
status: accepted PR that has been reviewed and accepted tag: tooling Related to the configuration of infrastructure and tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jezdez @mattkram @fpliger
0