CI Improvements; more focused runs and best practices #236
Conversation
8ec298d to
4b85380
Compare
|
I've actually got a - repo: https://github.com/pre-commit/mirrors-eslint
rev: 'v8.14.0'
hooks:
- id: eslint
additional_dependencies:
- eslint@>=5.16.0
- eslint-config-google@latest |
|
I added that to pre-commit @mattkram but it's failing - looks like the path is wrong. Not really seeing what argument is used to change that in the docs, but it's defaulting to /code/... |
|
Oh, I may need to give you a config file. Lemme try locally. |
.pre-commit-config.yaml
Outdated
| - id: eslint | ||
| additional_dependencies: | ||
| - eslint@>=5.16.0 | ||
| - eslint-config-google@latest |
There was a problem hiding this comment.
⛔️ means that GitHub wants files to end with one and 8000 only one \n
|
@pww217 Let's keep this in This is tough because |
|
Already deleted eslint from pre-commit for now. |
* add path filtering * small improvements for clarity, more focused run triggers, best practices * formatting * add js linting to pre-commit * Update .pre-commit-config.yaml * Update .pre-commit-config.yaml
Small changes, as the title says.
Question though: is there any overlap between the pre-commit python linting and Philipp's
lint.yaml? The latter looks like JS linting, but want to confirm so there's no redundancy.If they're different, may be possible to add that to
pre-commitas well. Up to y'all.