Don't load distutils in the Python standard library #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
May 5, 2022
There was a problem hiding this comment.
Thanks @rth! Really appreciate all the guidance you can give us. Sad to miss the meeting later but it's a bit late on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is a deprecated and quite large (around to 1MB) stdlib module that would be removed in Python 3.12 .
Most users likely don't need it, and if they do, they can add it explicitly as a dependency in py-env.
This PR disables loading it by default. Though maybe it would be good to wait until examples are tested #152 before merging this, just in case.