8000 Fix #2302 - Updated Polyscript to its latest by WebReflection · Pull Request #2303 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Fix #2302 - Updated Polyscript to its latest #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

Fix #2302 - Updated Polyscript to its latest #2303

merged 2 commits into from
Feb 27, 2025

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes #2302 and it's being tested both locally and remotely.

Changes

  • Updated Polyscript to its latest
  • tested the original demo works both in PyScript .com and localhost

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll February 27, 2025 09:45
@WebReflection
Copy link
Contributor Author
WebReflection commented Feb 27, 2025 •
edited
Loading

@ntoll this has been already published on npm as https://cdn.jsdelivr.net/npm/@pyscript/core@0.6.34/dist/core.js and its https://cdn.jsdelivr.net/npm/@pyscript/core@0.6.35/dist/core.css counterpart.

The demo looks good now and no issue whatsoever both remotely and locally.

@ntoll
Copy link
Member
ntoll commented Feb 27, 2025

Ugh. CI is complaining about single vs double quotes. 😬

@WebReflection
Copy link
Contributor Author

yeah ... it's complaining about tests ... so annoying!

@ntoll
Copy link
Member
ntoll commented Feb 27, 2025

Quis custodiet ipsos custodes? 😛

@WebReflection WebReflection force-pushed the issue-issue-2302 branch 5 times, most recently from 2ecde13 to 23cfaed Compare February 27, 2025 10:02
ntoll
ntoll approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member
@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh CI.

@WebReflection WebReflection merged commit 290eb03 into main Feb 27, 2025
2 checks passed
@WebReflection WebReflection deleted the issue-issue-2302 branch February 27, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run local wheels
2 participants
@WebReflection @ntoll
0