8000 Enable service-worker attribute for donkey worker by JoshuaLowe1002 · Pull Request #2263 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Enable service-worker attribute for donkey worker #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2024
Merged

Enable service-worker attribute for donkey worker #2263

merged 2 commits into from
Dec 19, 2024

Conversation

JoshuaLowe1002
Copy link
Member

Description

Enables the service worker attribute for the donkey worker plugin to allow the service worker operation mode

Changes

  • Add serviceWorker option to enable service-worker attribute in donkey plugin

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

WebReflection
WebReflection approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor
@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something we should tackle at the documentation level, as this is somehow a hidden feature in polyscript, not advertised as it should be for other plugins

@WebReflection WebReflection merged commit 7adedcc into pyscript:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebReflection WebReflection WebReflection approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaLowe1002 @WebReflection
0