8000 Added __terminal__ in non-persistent donkey by WebReflection · Pull Request #2260 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Added __terminal__ in non-persistent donkey #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

Added __terminal__ in non-persistent donkey #2260

merged 1 commit into from
Dec 6, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes an issue encountered by @JoshuaLowe1002 where the __terminal__ special variable is not exposed if the donkey is not persistent.

Changes

  • add a __terminal__ reference when terminal option is present and the persistent one is not True
  • test everything works as expected

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection
Copy link
Contributor Author

Already published on npm as https://cdn.jsdelivr.net/npm/@pyscript/core@0.6.22/dist/core.js

JoshuaLowe1002
JoshuaLowe1002 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member
@JoshuaLowe1002 JoshuaLowe1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@WebReflection WebReflection merged commit d143b22 into pyscript:main Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLowe1002 JoshuaLowe1002 JoshuaLowe1002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @JoshuaLowe1002
0