Cleanup pyscript web elements #2094

fpliger · 2024-06-05T23:03:36Z

Description

Changes

Checklist

All tests pass locally
I have updated CHANGELOG.md
I have created documentation for this(if applicable)

…he pyscript.web.dom module

for more information, see https://pre-commit.ci

…OCALLY NOW

…into pydom_pyweb_to_stdlib

for more information, see https://pre-commit.ci

…a specific selector so it now returns an empty collection

…into pydom_pyweb_to_stdlib

… appending elements.Element or a JsProxy object

…g nodeList as well

for more information, see https://pre-commit.ci

WebReflection · 2024-06-06T13:44:28Z

@fpliger there is a merge conflict but the other one looked OK to me after you rlatest cleanup so I've merged it but I wouldn't know how to resolve those conflicts ... any clue?

8000

fpliger · 2024-06-06T14:14:00Z

@WebReflection
I made a mistake and opened it towards main instead of pydom_pyweb_to_stdlib (this PR #2092) . We were going to keep #2092 as a gate keeper and were going to merge this and the next couple PR there to not have an instable main . I also didn't put a disclaimer on that PR stating that 🤦 so the PR got merged this morning but doesn't change much....

I'll take care of the conflicts and merge later today and just merge all the next PRs to main.

WebReflection · 2024-06-06T14:29:08Z

@fpliger I thought you made it back to ready for review (but it was already approved) to have it in ... my bad, I should've waited or asked more ... we just released though, we have time to make changes and fixes ... arguably we could also reverse that merge, that's what git is good at 😉

if you have everything under control though, I let you fix the current state, thanks

fpliger · 2024-06-06T14:42:18Z

ehehe, no worries at all. My bad really.. we were rushing yesterday evening because it was already late so I ended up forgetting both to mention that in the PR and not opening the other PR towards this one. I'm working on it today with @mchilvers and I hope we can get main to a stable state today or tomorrow the latest. 👍 (== before we release again)

ntoll

@WebReflection / @fpliger please have a quick look over this. @mchilvers and I paired on this yesterday and we both feel it's in a ready-to-merge state with a few refinements for the future.

Top of my mind for future refinement is a sort of "minification" strategy in our build step:

Python indentation from four spaces to one space.
Remove all # comments
De-black multiline parenthesis statements. E.g.

x = ("foo", "bar", "baz")  # this
x = (  # Not this
  "foo",
  "bar",
  "baz",
)

A good starting place for this might be a tool like pyminifier which does most of what we want in a vaguely configurable manner. 👍

I'm going to update the docs in line with the changes in this PR.

ntoll · 2024-06-28T08:56:58Z

pyscript.core/types/exceptions.d.ts

@@ -53,4 +53,19 @@ export class InstallError extends UserError {
 /**
 * Keys of the ErrorCode object
 */
-export type ErrorCodes = "GENERIC" | "CONFLICTING_CODE" | "BAD_CONFIG" | "MICROPIP_INSTALL_ERROR" | "BAD_PLUGIN_FILE_EXTENSION" | "NO_DEFAULT_EXPORT" | "TOP_LEVEL_AWAIT" | "FETCH_ERROR" | "FETCH_NAME_ERROR" | "FETCH_UNAUTHORIZED_ERROR" | "FETCH_FORBIDDEN_ERROR" | "FETCH_NOT_FOUND_ERROR" | "FETCH_SERVER_ERROR" | "FETCH_UNAVAILABLE_ERROR";
+export type ErrorCodes = keyof {


@WebReflection any idea why this might have changed? I'm asking because I think this file has been automatically "cleaned" by a linting tool or autogenerated in some way and I don't have the context for why such a change might have taken place.

for more information, see https://pre-commit.ci