8000 Patch js.document out of the box by WebReflection · Pull Request #1880 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Patch js.document out of the box #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

Patch js.document out of the box #1880

merged 3 commits into from
Dec 4, 2023

Conversation

WebReflection
Copy link
Contributor

Description

This MR solves the discussion we had in #1878 by attaching to the worker js module the document from main out of the box.

Changes

  • when running in worker, patch the js module with a document
  • smoke-test everything works as expected

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

JeffersGlass
JeffersGlass approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor
@JeffersGlass JeffersGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WebReflection WebReflection merged commit 8e5605f into pyscript:main Dec 4, 2023
@WebReflection
Copy link
Contributor Author

I think this was a mistake because it still requires one to import pyscript module to make it work ... I will amend today this MR so that we can actually land this feature instead of needing pyscript module as that makes the whole thing kinda pointless ...

@WebReflection WebReflection mentioned this pull request Dec 6, 2023
Merged
3 tasks
WebReflection added a commit that referenced this pull request Dec 6, 2023
@WebReflection
Amend #1880 - Bootstrap pyscript module ASAP (#1888)
96e671b 
  * bootstrap *pyscript* module ASAP as stdlib
  * improve the test to be sure `js.document` exists **before** our module is imported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffersGlass JeffersGlass JeffersGlass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @JeffersGlass
0