Fix #1812 - Avoid duplicated pyscript module #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntoll
approved these changes
Oct 26, 2023
|
To whom it might concern, this fixes the general bug on MicroPython on main, but it doesn't fix the underlying issue MicroPython, differently from Pyodide, throws unexpected errors when executed multiple times on main. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR avoids duplicated FileSystem module pollution on main, as that's already part of the code in main hooks story and as that fails, actually rightly so somehow, in MicroPython only.
Changes
codeBeforeRunthanks to the shared dance and behavior of latest changes.Checklist
docs/changelog.md