make append as False in display #1807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ def test_simple_display(self): | |||
| <script type="py"> | |||
| print('ciao') | |||
| from pyscript import display | |||
| display("hello world") | |||
| display("hello world", append=True) | |||
There was a problem hiding this comment.
I think, if we want to be sure about any default, we can keep one of these without the append field ... what do you think?
| @@ -202,8 +202,8 @@ def test_multiple_display_calls_same_tag(self): | |||
| """ | |||
| <script type="py"> | |||
| from pyscript import display | |||
| display('hello') | |||
| display('world') | |||
| display('hello', append=True) | |||
There was a problem hiding this comment.
same here ... if we really want to be sure append=True is the default, we should keep this not touched to me
|
I believe we agreed on discord, that the default should be |
|
Thanks @WebReflection and @ntoll In that case, let's close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation mentions that
appendin display is False by default. But it really wasn't.So the docs were kinda wrong, see here: https://docs.pyscript.net/2023.09.1.RC2/user-guide/#pyscriptdisplay
Also, this PR builds on top of #1806 which fixed a typo from
FlasetoFalse.Even with the typo however, the docs were kinda wrong.