8000 Fix #1799 - Avoid multiple bootstraps when embedded by WebReflection · Pull Request #1800 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Fix #1799 - Avoid multiple bootstraps when embedded #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix #1799 - Avoid multiple bootstraps when embedded #1800

merged 2 commits into from
Oct 23, 2023

Conversation

WebReflection
Copy link
Contributor

Description

This MR is a follow up of the polyscript approach pyscript/polyscript#59 to avoid ever dealing with multiple versions of the project in the wild, as discussed in #1799 + it uses the latest polyscript to also stop having issues when embedded by other tools.

Changes

  • use the latest polyscript/exports to import all utilities and internal needed to make PyScript work
  • use the same global, Symbol based, guard to avoid ever registering or bootstrapping PyScript twice, allowing multiple embedded projects to effectively share hooks too

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection mentioned this pull request Oct 11, 2023
Closed
ntoll
ntoll approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member
@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit a24113f into pyscript:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll
0