Update Makefile #1793
Update Makefile #1793
Conversation
|
OK... looks like |
|
Couple things:
pyscript/.github/workflows/test.yml Line 68 in 4256a81
pyscript/pyscript.core/README.md Line 44 in 4256a81 |
|
Thanks @JeffersGlass, this is why it's a draft! 😄 Once merged, this change will mean our setup docs are super simple. :-) I'll update the README as part of this PR in subsequent commits. 🎉 |
|
@JeffersGlass upon refection I've retained the |
|
Did I mention how much I hate YAML and GitHub actions? 🤣 I'll squash and take this out of draft. |
53f7be5 to
56b1b1a
Compare
|
OK... checking of Python versions still doesn't work. Fixing (again). |
| fi | ||
|
|
||
| # Check the environment, install the dependencies. | ||
| setup: check-node check-npm check-python |
There was a problem hiding this comment.
Are we missing a command here to actually create the virtual environment? I see your docs PR says "Simply create a virtual environment", but in my experience that process is not necessarily simple...
If we're recommending python3 -m venv my_pyscript_dev_venv maybe we just put that in the makefile as well, either under setup or as a separate command, just to lower friction?
There was a problem hiding this comment.
Hi @JeffersGlass - good question and one that I agonised over.
On the one hand, for absolute beginners, that might be quite useful.
But on the other non-beginners or tech folk won't have too much of a problem understanding both the concept and that there are many ways to skin that cat (in the docs see here, using virtualenvmanager, pyenv, the IDE, whatever).
So I assumed technical know how and the choice to configure that aspect of one's environment oneself.
Like I said, happy to be persuaded otherwise.
ad10f53 to
7f104fd
Compare
|
OK... I've revised in light of comments. Can we approve? |
…ss type annotations. Update CI tests.yml.
1fcb944 to
09221b9
Compare
Description
Our top level
Makefilewas complicated and contained cruft. This PR simplifies things so a new maintainers set-up process is simple. After discord based discussion we've dropped conda for the more widespread venv/pip way to manage Python dependencies.PLEASE CHECK: If the
Makefileis used by GitHub actions or other CI related tasks - please let me know.Changes
This PR makes the following changes:
requirements.txtfor Python dependencies.Checklist
docs/changelog.md