8000 Fix #1780 - Clean up elements before writing by WebReflection · Pull Request #1781 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Fix #1780 - Clean up elements before writing #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix #1780 - Clean up elements before writing #1781

merged 1 commit into from
Oct 2, 2023

Conversation

WebReflection
Copy link
Contributor

Description

This MR takes the easy approach on issue #1780 by simply cleaning up target elements when append=False or any explicit not append is passed along.

Changes

  • cleanup the target before any operation when append=False or append=None is passed

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

WebReflection
WebReflection commented Oct 2, 2023
View reviewed changes
WebReflection
WebReflection commented Oct 2, 2023
View reviewed changes
JeffersGlass
JeffersGlass approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor
@JeffersGlass JeffersGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@WebReflection WebReflection merged commit bc1cac9 into pyscript:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffersGlass JeffersGlass JeffersGlass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @JeffersGlass
0