Improved py:all-done event #1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antocuni
reviewed
Oct 2, 2023
| from pyscript import display | ||
| display('hello 3') | ||
| </script> | ||
| </body> |
There was a problem hiding this comment.
this should become a proper integration test
There was a problem hiding this comment.
we could do a follow up but the feature is from polyscript so eventually tests should be done there, imho.
There was a problem hiding this comment.
actually, never mind, these probably should be done in both places because custom types events are not polyscript matter anymore ... that being said, we currently have time working in either sync or async scripts/elements ... not sure how to test this best as async and time don't really use async feature there. If you'd like to add a better test, please go ahead, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes an issue with
py:all-doneevent by using events instead of hooks as hooks require awkward main thread orchestrations while events are always grant to land in there thanks to latest polyscript update.Changes
py:all-doneevent by using those eventsChecklist
docs/changelog.md