8000 WIP: py-terminal plugin by antocuni · Pull Request #1771 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

WIP: py-terminal plugin #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

WIP: py-terminal plugin #1771

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6408ffa
a very hacky and very very tentative implementation sketchy implement…
antocuni Sep 29, 2023
e333813
improve the comments
antocuni Sep 29, 2023
778d37e
use a better approach for pyodide
antocuni Sep 29, 2023
70e9611
rename
antocuni Sep 29, 2023
89c2124
WIP: I don't understand why onWorkerReady is not called
antocuni Sep 29, 2023
1867b8b
Merge remote-tracking branch 'origin/main' into antocuni/py-terminal
antocuni Sep 29, 2023
eaf4da7
hack hack hack until pyterminal works also in workers
antocuni Sep 29, 2023
90b3825
undo this change
antocuni Oct 5, 2023
e2d27d2
Merge remote-tracking branch 'origin/main' into antocuni/py-terminal
antocuni Oct 5, 2023
b60327f
we can kill this ugly hack now
antocuni Oct 5, 2023
e1bf510
use lazy imports and import xterm.js only if a py-terminal is actuall…
antocuni Oct 5, 2023
8c64d42
missing file
antocuni Oct 10, 2023
84feb83
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve the comments
  • Loading branch information
@antocuni
antocuni committed Sep 29, 2023
commit e333813fa1fa19b07fef73df94e1d7db3516d423
7 changes: 4 additions & 3 deletions pyscript.core/src/plugins/pyterminal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,15 @@ addEventListener("py:ready", (event) => {
xworker.sync.pyterminal_write = t.write;

// XXX: I know that the following lines don't work, but this is more or
// lesswhat I would like to happen
pyScript.io.stdout = (s, ...rest) => {
// less what I would like to happen
const something = ???;
something.io.stdout = (s, ...rest) => {
// this is JS code, and we cannot send arbitrary JS code from the main
// to the worker. So maybe a solution is to hardcode this logic
// directly inside the worker code?
xworker.sync.pyterminal_write(s);
}
pyScript.io.stderr = (s, ...rest) => {
something.io.stderr = (s, ...rest) => {
xworker.sync.pyterminal_write(s);
}
something.runPython(`
Expand Down
0