Enable worker tests #1757

antocuni · 2023-09-25T17:00:07Z

This PR re-enables tests on workers.
Highlights:

by default, each test is run twice: the main thread version uses <script type="py">, the worker version automatically turn the tags into <script type="py" worker>
you can tweak the settings per-class by using the @with_execution_thread decorator. In particular, @with_execution_thread(None) is for those tests which don't care about it (e.g., test_py_config.py)
inside each class, there might be some test which should be run only in the main thread (because it doesn't make sense to test it in a worker). For those, I introduced the @only_main decorator
we might introduce @only_worker in the future, if needed
@skip_worker is for those tests which currently pass on main but not on workers. These are meant to be temporary, and eventually they should all be fixed

During the process, I tweaked/improved/fixed/deleted some of the existing tests. Some of them were at risk of being flaky and I made them more robust, others depended on some very precise implementation detail, and I made them more generic (for example, test_image_renders_correctly relied on pillow to render an image with a very specific string of bytes, and it broke due to the recent upgrade to pyodide 0.24.1)

I also renamed all the skip messages to start with NEXT, so that they are easier to grep.

Next steps

re-enable automatic test run on all PRs (if someone wants to volunteer to do that, it would be welcome :))
open an umbrella issue to examine/explain/group all the tests which are currently skipped on main
open an umbrella issue to examine/explain/group all the tests which are currently skipped on worker

antocuni · 2023-09-25T17:04:58Z

@JeffersGlass to continue the conversation started in the other PR, here is my WIP PR which among the other things fixes wait_for_pyscript.
This is the relevant commit: 1571841

At the moment it's a ugly hack because it hardcodes a console.debug() instead of using a hook, and the equivalent for the case of workers is even uglier (note that in this case it's python code, not JS code):

pyscript/pyscript.core/src/core.js

Lines 91 to 103 in 588eda8

    
           // XXX (antocuni): this is a hack, we need to find a better way to do this 
        
           const afterRunWorker = "import js; js.console.debug('---pyscript: done---')" 
        
           const workerHooks = { 
        
               codeBeforeRunWorker: () => 
        
                   [stdlib, ...hooks.codeBeforeRunWorker].map(dedent).join("\n"), 
        
               codeBeforeRunWorkerAsync: () => 
        
                   [stdlib, ...hooks.codeBeforeRunWorkerAsync].map(dedent).join("\n"), 
        
               codeAfterRunWorker: () => 
        
                   [...hooks.codeAfterRunWorker, afterRunWorker].map(dedent).join("\n"), 
        
               codeAfterRunWorkerAsync: () => 
        
                   [...hooks.codeAfterRunWorkerAsync, afterRunWorker].map(dedent).join("\n"), 
        
           };

@WebReflection is working on a better solution which uses hooks instead of hardcoding the prints.

…finished their execution

…able worker tests

…ide 0.24.1, probably because of a different pillow version

WebReflection · 2023-09-26T18:34:08Z