8000 Fixed eslint ignoring global leaks by WebReflection · Pull Request #1754 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Fixed eslint ignoring global leaks #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fixed eslint ignoring global leaks #1754

merged 1 commit into from
Sep 25, 2023

Conversation

WebReflection
Copy link
Contributor

Description

Last Friday we had an issue due eslint recommendation not spotting global leaks in a single function and I was a bit horrified by the fact nothing was shown in console and the build went through it.

Changes

  • ignore top level folders as we have pre-commit hooks there anyway as extra guard but actually enforce eslint checks on code and syntax for the src folder without enforcing styles
  • test that if that type signature reference is out the build fails so we can sleep better at night

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

ntoll
ntoll approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member
@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice catch.

@WebReflection WebReflection merged commit f0be7ef into pyscript:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll
0