8000 [RC] Work on the reverted changes by WebReflection · Pull Request #1753 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

[RC] Work on the reverted changes #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

[RC] Work on the reverted changes #1753

merged 1 commit into from
Sep 25, 2023

Conversation

WebReflection
Copy link
Contributor
@WebReflection WebReflection commented Sep 25, 2023 •
edited
Loading

Description

This MR re-revert needed changes to make multiple config working on current RC which is otherwise broken.

Changes

  • revert the removal of the code putting back TS definitions
  • actually fix the type bug spotted in the live example (it was a typo around TOML config that prettier didn't catch at all)
  • test everything works as expected
  • added the test page that was failing

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

ntoll
ntoll approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member
@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo. :shipit:

@WebReflection
Copy link
Contributor Author
WebReflection commented Sep 25, 2023 •
edited
Loading

Before this MR
Screenshot from 2023-09-25 11-37-05

After this MR
Screenshot from 2023-09-25 11-37-27

@WebReflection WebReflection merged commit e4eedd8 into pyscript:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll
0