8000 fix access to interpreter globals without awaits by madhur-tandon · Pull Request #1529 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content

fix access to interpreter globals without awaits #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

madhur-tandon
Copy link
Member
@madhur-tandon madhur-tandon commented Jun 14, 2023

Description

Restores old behaviour of accessing pyscript.interpreter or pyscript.runtime as discussed here: #1489 (comment) during RC1 testing.

Changes

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

@madhur-tandon madhur-tandon requested a review from antocuni June 14, 2023 14:01
Copy link
Contributor
@antocuni antocuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the description of the PR should contain some more details explaining why this is needed, and e.g. a link to this discussion: #1489 (comment)

@madhur-tandon madhur-tandon merged commit 8879187 into pyscript:main Jun 14, 2023
@madhur-tandon madhur-tandon deleted the rc1-fix branch June 14, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0