8000 DOCS Update display.md by c-neli-r · Pull Request #1375 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content

DOCS Update display.md #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2023
Merged

DOCS Update display.md #1375

merged 2 commits into from
Apr 10, 2023

Conversation

c-neli-r
Copy link
Contributor
@c-neli-r c-neli-r commented Apr 10, 2023

Delete wrong code comments.

Description

Wrong comment for describing code was probably copied from the example above it

Delete wrong code comments.
@@ -45,8 +45,6 @@ To write compliant code, make sure to specify the target using the `target` para
```html
<py-script>
def display_hello():
# this fails because we don't have any implicit target
# from event handlers
display('hello', target="helloDiv")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implicit target is given here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

# this works because we give an explicit target

@hoodmane hoodmane changed the title Update display.md DOCS Update display.md Apr 10, 2023
@hoodmane
Copy link
Contributor

Thanks @cnelir98!

@hoodmane hoodmane merged commit c05195c into pyscript:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0