8000 Upgrade to Pyodide 0.23 by JeffersGlass · Pull Request #1347 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content

Upgrade to Pyodide 0.23 #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ce31e38
Upgrade to Pyodide 0.23.0
JeffersGlass Apr 1, 2023
7bccf09
Update cached files listing
JeffersGlass Apr 1, 2023
2221e12
changelog
JeffersGlass Apr 1, 2023
291c6ff
Address hood's comments
JeffersGlass Apr 1, 2023
feba2eb
Address more comments
JeffersGlass Apr 2, 2023
87ca3cf
Update timeout lengths
JeffersGlass Apr 10, 2023
7682bed
Bump pyodide to 0.23.2
JeffersGlass May 10, 2023
b42cf5a
Merge branch 'main' into pyodide-0-23-0
JeffersGlass May 10, 2023
74edd00
Bump kmeans timeout time
JeffersGlass May 10, 2023
92e385c
Use @parma decorator to get brush param
JeffersGlass May 10, 2023
870cd06
Add a comment to force CI run
JeffersGlass May 11, 2023
6c136b3
Separate example tests to run sequentially
JeffersGlass May 12, 2023
c3befef
Remove extraneous example build
JeffersGlass May 12, 2023
335810d
Remove unnecessary 'make examples'
JeffersGlass May 15, 2023
e36a2b3
Merge branch 'main' into pyodide-0-23-0
JeffersGlass May 15, 2023
897af7b
Adjust makefile and rerun CI
JeffersGlass May 15, 2023
9197a3f
Remove pytest.raises from test, use check_js_errors
JeffersGlass May 15, 2023
413aefa
Add 'check_js_errors' to wait_for_pyscript
JeffersGlass May 15, 2023
0443dfc
Cleanup PR
JeffersGlass May 15, 2023
d91610c
Address some comments
JeffersGlass May 16, 2023
e7d5190
Adjust comment
JeffersGlass May 16, 2023
3e7114d
Rollback change to version check?
JeffersGlass May 16, 2023
c3ae4bd
Add comment on version
JeffersGlass May 21, 2023
f2d4b09
Merge branch 'main' into pyodide-0-23-0
JeffersGlass May 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup PR
  • Loading branch information
JeffersGlass committed May 15, 2023
commit 0443dfcfc32e03391b6c6fa50a9fd4049b352b07
3 changes: 0 additions & 3 deletions pyscriptjs/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ import * as Synclink from 'synclink';

const logger = getLogger('pyscript/main');

// This comment is to force CI to run again on this branch, and will be removed
// before final review

/**
* Monkey patching the error transfer handler to preserve the `$$isUserError`
* marker so as to detect `UserError` subclasses in the error handling code.
Expand Down
2 changes: 1 addition & 1 deletion pyscriptjs/src/remote_interpreter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export class RemoteInterpreter extends Object {
* */
async loadPackage(names: string | string[]): Promise<void> {
logger.info(`pyodide.loadPackage: ${names.toString()}`);
// the new way in Pyodode 0.22.0 and later a locally downloaded older version of pyodide
// the new way in Pyodode 0.22 and later a locally downloaded older version of pyodide
// for which the signature of `loadPackage` accepts the above params as args i.e.
// the call uses `logger.info.bind(logger), logger.info.bind(logger)`.
const messageCallback = logger.info.bind(logger) as typeof logger.info;
Expand Down
2 changes: 1 addition & 1 deletion pyscriptjs/tests/integration/test_py_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def test_py_config_external(self):

# The default pyodide version is newer than
# the one we are loading below (after downloading locally)
# which is 0.20.0
# which is 0.22.0

# The test checks if loading a different interpreter is possible
# and that too from a locally downloaded file without needing
Expand Down
1 change: 1 addition & 0 deletions pyscriptjs/tests/integration/test_zzz_docs_snippets.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def test_tutorials_py_config_fetch(self):
self.assert_no_banners()

def test_tutorials_py_config_interpreter(self):
"""Load a previous version of Pyodide"""
self.pyscript_run(
"""
<py-config>
Expand Down
0