Deprecate py-mount Attribute
#1330
Conversation
There was a problem hiding this comment.
+1 for deprecating py-mount, thanks for doing it 🤩
Also added a section of the deprecation docs for tracking what's currently being deprecated so that we actually remember to remove deprecated things in a future release.
yes, ideally I would like a better approach for deprecations, .e.g. something that automatically warns us in case some old deprecations are still in the code. It could be something as simple as a special comment and a test which greps all the source code, looking for the ones which are "too old".
Maybe we should add it to our release procedure and kill all deprecations as soon as we do a release (this should work since we have the policy of waiting only 1 release for deprecations).
Speaking of which, we also need to kill this code:
pyscript/pyscriptjs/src/python/pyscript/__init__.py
Lines 631 to 635 in 3ae4b3c
+1 to both having a test for it in some way, and in making it a part of our process to killing deprecations immediately after releases. |
As described in #1220, the
py-mountattribute isn't a feature we really advertise, nor make use of anywhere else in the codebase. It was meant to mount HTML elements directly as pyscriptElements, but that's nor really a part of the API we're suggesting at this point.Also added a section of the deprecation docs for tracking what's currently being deprecated so that we actually remember to remove deprecated things in a future release. 😅
Fixes #1220