8000 Update changelog date by FabioRosado · Pull Request #1289 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content

Update changelog date #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

FabioRosado
Copy link
Contributor

Description

While chatting with @WebReflection I noticed that our changelog had the wrong date, it seems we forgot to update it before we did a release 😄

Changes

Updates the changelog date to the proper one

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

Copy link
Contributor
@JeffersGlass JeffersGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Seems like we should probably have some documentation about what we do before/during a release 😅

@marimeireles
Copy link
Contributor

Someone else changed to 2023.XX.X. Personally I like it better as we're not sure if we're releasing on March (seems like not?)
So I'd advocate for closing this.

@FabioRosado
Copy link
Contributor Author
FabioRosado commented Mar 23, 2023

The date change is from the previous changelog not the new changelog entry that @WebReflection added :)

@marimeireles
Copy link
Contributor

Aha, thanks, sorry. So please go ahead!

@FabioRosado FabioRosado merged commit a62aba8 into pyscript:main Mar 23, 2023
@FabioRosado FabioRosado deleted the fr/changelog-date branch March 23, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0