8000 Set pre-commit autoupdate to monthly by hoodmane · Pull Request #1271 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Set pre-commit autoupdate to monthly #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2023
Merged

Set pre-commit autoupdate to monthly #1271

merged 2 commits into from
Mar 23, 2023

Conversation

hoodmane
Copy link
Contributor
@hoodmane hoodmane commented Mar 9, 2023

Weekly autoupdate creates a lot of noise. Quarterly is more reasonable.

@hoodmane
Set pre-commit autoupdate to quarterly
e3711a5 
Weekly autoupdate creates a lot of noise
8000
@cclauss
Copy link
Contributor
cclauss commented Mar 10, 2023

Quarterly seems like stuff could get a bit stale. Monthly is just 12 times a year. Relatively fresh with a low level of noise.

@hoodmane
Copy link
Contributor Author

Yeah maybe we should switch Pyodide to monthly too @rth. We have a lot of repos so when there are updates it gets very noisy. But merging 10 autogenerated pull requests isn't much work really.

@cclauss do you know how to make the pre-commit.ci bot reapply updates when there's a merge conflict? I couldn't figure out how the other day.

@rth
Copy link
Contributor
rth commented Mar 11, 2023 •
edited
Loading

Yes, fine with monthly. At some point, I switched other repos to quarterly as I was tired of getting constant notifications from pre-commit.ci which still takes some attention bandwidth. But monthly work too.

cclauss
cclauss reviewed Mar 11, 2023
View reviewed changes
@cclauss
Copy link
Contributor
cclauss commented Mar 11, 2023

to make the pre-commit.ci bot reapply updates

https://pre-commit.ci/#configuration-autoupdate_schedule says:

re-running a pull request: you can trigger a re-run on a pull request by commenting pre-commit.ci run (must appear on a line by itself).

So...
pre-commit.ci run

@hoodmane
Copy link
Contributor Author

Thanks @cclauss. I guess it was just poor reading comprehension on my part since it says it right there...

@hoodmane @cclauss
Update .pre-commit-config.yaml
98ec887 
Co-authored-by: Christian Clauss <cclauss@me.com>
@hoodmane hoodmane changed the title Set pre-commit autoupdate to quarterly Set pre-commit autoupdate to monthly Mar 13, 2023
JeffersGlass
JeffersGlass approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor
@JeffersGlass JeffersGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marimeireles
Copy link
Contributor

Merging it then =) since hood doesn't have contributors rights afaiu.
Thanks folks!

@marimeireles marimeireles merged commit 89842e2 into pyscript:main Mar 23, 2023
@hoodmane hoodmane deleted the precommit-update-quarterly branch March 23, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffersGlass JeffersGlass JeffersGlass approved these changes

@cclauss cclauss cclauss approved these changes

@madhur-tandon madhur-tandon madhur-tandon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hoodmane @cclauss @rth @marimeireles @JeffersGlass @madhur-tandon
0