8000 Fix many ESlint errors by hoodmane · Pull Request #1265 · pyscript/pyscript · GitHub
[go: up one dir, main page]

Skip to content

Fix many ESlint errors #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
564e1e1
Unvendor toml package
hoodmane Mar 8, 2023
04ae065
Fix many ESlint errors
hoodmane Mar 8, 2023
6ae4d7f
Put back Record
hoodmane Mar 8, 2023
144efac
Fix typescript compilation
hoodmane Mar 8, 2023
09be677
Merge branch 'unvendor-toml' into fix-lints
hoodmane Mar 8, 2023
ad00491
Fix lints
hoodmane Mar 8, 2023
2e158d4
Try @iarna/toml instead
hoodmane Mar 8, 2023
ed61b1e
Fix import
hoodmane Mar 8, 2023
81b4c35
Use @ltd/j-toml
hoodmane Mar 8, 2023
81878c8
Update test
hoodmane Mar 8, 2023
dcdfc93
Use toml-j0.4
hoodmane Mar 8, 2023
6154b5c
Merge branch 'unvendor-toml' into fix-lints
hoodmane Mar 8, 2023 < 8000 /span>
3c6fe2d
Some changes
hoodmane Mar 8, 2023
54ab4b3
Fix toml import
hoodmane Mar 9, 2023
8bb9ec4
Merge branch 'unvendor-toml' into fix-lints
hoodmane Mar 9, 2023
40324ab
Try adding eslint gha job
hoodmane Mar 9, 2023
d68c6e7
Add forgotten checkout action
hoodmane Mar 9, 2023
bcb9d92
Force CI to run
hoodmane Mar 9, 2023
336782a
Blah
hoodmane Mar 9, 2023
054ada0
Fix
hoodmane Mar 9, 2023
859f127
Revert changes to github workflow
hoodmane Mar 9, 2023
281328b
Merge branch 'main' into fix-lints
hoodmane Mar 9, 2023
06ea704
Fix lints
hoodmane Mar 9, 2023
c36eb05
wget toml-j0.4 type definitions
hoodmane Mar 9, 2023
be92a41
Merge branch 'main' into fix-lints
hoodmane Mar 9, 2023
46efde1
Add toml-j types workaround to eslint workflow
hoodmane Mar 9, 2023
999d43c
Apply formatter
hoodmane Mar 9, 2023
cd4e014
Merge branch 'main' into fix-lints
hoodmane Mar 13, 2023
8963fe6
Use @hoodmane/toml-j0.4
hoodmane Mar 13, 2023
80dff89
Import from @hoodmane/toml-j0.4
hoodmane Mar 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use toml-j0.4
  • Loading branch information
hoodmane committed Mar 8, 2023
commit dcdfc937c89f2d50959a9a299166c8bb2377bd7b
24 changes: 12 additions & 12 deletions pyscriptjs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyscriptjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@codemirror/state": "6.1.2",
"@codemirror/theme-one-dark": "6.1.0",
&qu ED4B ot;@codemirror/view": "6.3.0",
"@ltd/j-toml": "^1.38.0",
"codemirror": "6.0.1"
"codemirror": "6.0.1",
"toml-j0.4": "^1.1.1"
}
}
2 changes: 1 addition & 1 deletion pyscriptjs/src/pyconfig.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as toml from '@ltd/j-toml';
import * as toml from 'toml-j0.4';
import { getLogger } from './logger';
import { version } from './version';
import { getAttribute, readTextFromPath, htmlDecode, createDeprecationWarning } from './utils';
Expand Down
5 changes: 3 additions & 2 deletions pyscriptjs/tests/integration/test_py_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,11 @@ def test_invalid_toml_config(self):
wait_for_pyscript=False,
)
banner = self.page.wait_for_selector(".py-error")
assert "SyntaxError: Empty bare key" in self.console.error.text
assert "SyntaxError: Expected DoubleQuote" in self.console.error.text
expected = (
"(PY1000): The config supplied: [[ is an invalid TOML and cannot be parsed: "
"SyntaxError: Empty bare key at line 1: [["
"SyntaxError: Expected DoubleQuote, Whitespace, or [a-z], [A-Z], "
'[0-9], "-", "_" but "\\n" found.'
)
assert banner.inner_text() == expected

Expand Down
0