8000 Py Terminal issues aggregation · Issue #1940 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Py Terminal issues aggregation #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
WebReflection opened this issue Jan 15, 2024 · 1 comment · Fixed by #1941
Closed
6 tasks done

Py Terminal issues aggregation #1940

WebReflection opened this issue Jan 15, 2024 · 1 comment · Fixed by #1941
Labels
needs-triage Issue needs triage type: bug Something isn't working

Comments

@WebReflection
Copy link
Contributor
WebReflection commented Jan 15, 2024 •
edited
Loading

Checklist

  • I added a descriptive title
  • I searched for other issues and couldn't find a solution or duplication
  • I already searched in Google and didn't find any good information or help

What happened?

We have at least 3 issues in the current PyTerminal:

What browsers are you seeing the problem on? (if applicable)

No response

Console info

No response

Additional Context

No response
@WebReflection WebReflection added type: bug Something isn't working needs-triage Issue needs triage labels Jan 15, 2024
@WebReflection WebReflection mentioned this issue Jan 15, 2024
Merged
3 tasks
@WebReflection
Copy link
Contributor Author

After testing this MR I've noticed that the config resolution is too smart on polyscript side so that it cannot land as fix for PyScript.

If curious, PyScript passes an already parsed config, first come first serve, from main, so that polyscript ends up resolving that config URL automatically, based on the invoking script when no other hints are provided.

This causes an obvious discrepancy between config pre-parsed on main, where the config base URL would be that main script one, and config parsed as file (or via workers, hence always files).

This issue needs more testing and thinking around how polyscript can help there bypassing "magic" allowing pre-parsed configs, at least for custom types, to have a well understood base, where me and @ntoll agreed that where the config file was originally hosted should dictate the base root/path for that config, like any relative URL is supposed to work.

Opening an issue in Polyscript as we speak.

@WebReflection WebReflection mentioned this issue Jan 15, 2024
Closed
WebReflection added a commit that referenced this issue Jan 15, 2024
@WebReflection
Fix #1940 - Handle Main Xterm as tty too (#1941)
1e7fb9a
@WebReflection WebReflection mentioned this issue Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Issue needs triage type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1940 - Handle Main Xterm as tty too WebReflection/pyscript
1 participant
@WebReflection
0