8000 Fix #77 - Allow `configURL` to be passed for custom types by WebReflection · Pull Request #78 · pyscript/polyscript · GitHub
[go: up one dir, main page]
Skip to content

Fix #77 - Allow configURL to be passed for custom types #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix #77 - Allow configURL to be passed for custom types #78

merged 1 commit into from
Jan 17, 2024

Conversation

WebReflection
Copy link
Contributor

This MR basically allows already parsed configs to work with the proper relative or absolute URL within fetch, files, or packages operations.

  • added a configURL field that overload the config when this is an object
  • still fallback to a local ./config.txt as it was doing before for backward compatibility
  • remove the circular dependency around io and stdio
  • resolve without breaking Worker callbacks as it's done in PyScript, exposing the same library too
  • added and tested a use case that used to fail when config as object was already passed and its files operations were breaking
  • updated documentation around such field

@WebReflection
Fix #77 - Allow configURL to be passed for custom types
b7819cd 
This MR basically allows already parsed configs to work with the proper
relative or absolute URL within fetch, files, or packages operations.

  * added a `configURL` field that overload the `config` when this is an object
  * still fallback to a local `./config.txt` as it was doing before for backward compatibility
  * remove the circular dependency around io and stdio
  * resolve without breaking Worker callbacks as it's done in PyScript, exposing the same library too
  * added and tested a use case that used to fail when config as object was already passed and its files operations were breaking
@WebReflection WebReflection merged commit 7b286a9 into main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WebReflection
0