This repository was archived by the owner on Dec 22, 2021. It is now read-only.
added eval plugin #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Add yourself in the readme |
delivrance
reviewed
Nov 7, 2018
plugins/eval/eval.py
Outdated
| eval_running_text = "**Eval Code:**\n```{code}```\n**Running...**" | ||
| eval_success_text = "**Eval Code:**\n```{code}```\n**Success**" | ||
| eval_error_text = "**Eval Code:**\n```{code}```\n**Error:**\n```{error}```" | ||
| eval_result_text = "**Eval Code:**\n```{code}```\n**Result:**\n```{result}```" |
There was a problem hiding this comment.
I like these to be UPPER_CASE
delivrance
reviewed
Nov 7, 2018
plugins/eval/eval.py
Outdated
| def evalcode(client, message): | ||
| code = " ".join(message.command[1:]) | ||
| if code: | ||
| m = client.send_message(message.chat.id, eval_running_text.replace('{code}', code), parse_mode="MARKDOWN") |
There was a problem hiding this comment.
Don't use replace, use format instead.
Also, you could just use message.reply here
delivrance
reviewed
Nov 7, 2018
delivrance
reviewed
Nov 7, 2018
plugins/eval/eval.py
Outdated
| else: | ||
| client.edit_message_text(message.chat.id, m.message_id, | ||
| eval_success_text.replace('{code}', code), | ||
| parse_mode="MARKDOWN") |
There was a problem hiding this comment.
Markdown is enabled by default, there's no need for it.
delivrance
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
There are quite a few fixes needed to make this plugin nicer. Here's how I suggest it to be instead (there's still some redundant code because of message.edit() not being available (yet), but we can add it later):
from pyrogram import Client, Filters
RUNNING = "**Eval Code:**\n```{}```\n**Running...**"
ERROR = "**Eval Code:**\n```{}```\n**Error:**\n```{}```"
SUCCESS = "**Eval Code:**\n```{}```\n**Success**"
RESULT = "**Eval Code:**\n```{}```\n**Result:**\n```{}```"
@Client.on_message(Filters.command("eval", prefix="!"))
def eval_code(client, message):
code = " ".join(message.command[1:])
if code:
m = message.reply(RUNNING.format(code))
try:
result = eval(code)
except Exception as error:
client.edit_message_text(
m.chat.id,
m.message_id,
ERROR.format(code, error)
)
else:
if result is None:
client.edit_message_text(
m.chat.id,
m.message_id,
SUCCESS.format(code)
)
else:
client.edit_message_text(
m.chat.id,
m.message_id,
RESULT.format(code, result)
)|
And here's how the plugin will look like as soon as from pyrogram import Client, Filters
RUNNING = "**Eval Code:**\n```{}```\n**Running...**"
ERROR = "**Eval Code:**\n```{}```\n**Error:**\n```{}```"
SUCCESS = "**Eval Code:**\n```{}```\n**Success**"
RESULT = "**Eval Code:**\n```{}```\n**Result:**\n```{}```"
@Client.on_message(Filters.command("eval", prefix="!"))
def eval_code(client, message):
code = " ".join(message.command[1:])
if code:
reply = message.reply(RUNNING.format(code))
try:
result = eval(code)
except Exception as error:
reply.edit(ERROR.format(code, error))
else:
if result is None:
reply.edit(SUCCESS.format(code))
else:
reply.edit(RESULT.format(code, result)) |
|
Wow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be
2C64
applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.