10000 Fix redisplay() missing & history-files with non-latin chars by ankostis · Pull Request #56 · pyreadline/pyreadline · GitHub
[go: up one dir, main page]
Skip to content

Fix redisplay() missing & history-files with non-latin chars #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix redisplay() missing & history-files with non-latin chars #56

wants to merge 4 commits into from

Conversation

ankostis
Copy link
@ankostis ankostis commented Jun 9, 2017

A band-aid PR that fixes #49 and #55 annoying bugs.

eric-wieser and others added 4 commits January 4, 2017 19:51
@eric-wieser
Implement readline.redisplay(), fixing pyreadline#49
f0ea9db
@ankostis
fix(PY36, pyreadline#51): PY36 missed redisplay() unless in __ALL__
0fa8d15
@ankostis
fix(pyreadline#51): redundant _print_prompt() printed PS1 if Tab on e…
0baaba5 
…mpty inp-line
@ankostis
fix(hist, pyreadline#55): reading history-files was leaking & failing…
e85c860 
… on non-Latin

+ Use io.open() to pass `encoding='utf-8'` when opening history-file.
+ Use `with ...` resource management not to leak file-handles.
+ The errors was: UnicodeDecodeError: 'charmap' codec can't decode byte
0x8f in position 1818: character maps to <undefined>
@ankostis ankostis mentioned this pull request Jun 9, 2017
would it be possible to remove dependancy on pyreadline ? uqfoundation/dill#181
Closed
@ankostis ankostis mentioned this pull request Jul 23, 2017
Closed
@s-m-e s-m-e mentioned this pull request Feb 21, 2019
Open
@musm
Copy link
musm commented Dec 25, 2020

sadly it looks like this will never be merged

@skywind3000
Copy link

Why not merge this ?

@Yurzi Yurzi mentioned this pull request Oct 9, 2021
Open
@brgirgis
Copy link

Please raise your PR here and we can do a quick release.

@ankostis
Copy link
Author
ankostis commented Jan 23, 2022 •
edited
Loading

Ok, done with brgirgis/pyreadline3#1

@eabase
Copy link
eabase commented Jan 25, 2022

@ankostis I think something got messed up, since @brgirgis deleted that repo in favor of pyreadline3:

@ankostis
Copy link
Author
ankostis commented Jan 25, 2022 •
edited
Loading

@brgirgis inform me when are you stabilized repos, to then push my PR
(please, don't delete stuff without notification, or else i don;t get the chance to salvage content).

@eabase thanks!

@brgirgis
Copy link

pyreadline3/pyreadline3 is the final destination. Sorry for the confusion.

@ankostis
Copy link
Author

note, you have broke fork-relationship, so now i don;t get a PR automatically when landing on the new repo :-(.

@ankostis
Copy link
Author

Ok, rewritten my original PR, please @brgirgis approve my workflow.

akruis pushed a commit to science-computing/pyreadline that referenced this pull request Sep 21, 2023
@ankostis
fix(hist, pyreadline#55): reading history-files was leaking & failing…
321ea24 
… on non-Latin

+ Use io.open() to pass `encoding='utf-8'` when opening history-file.
+ Use `with ...` resource management not to leak file-handles.
+ The errors was: UnicodeDecodeError: 'charmap' codec can't decode byte
0x8f in position 1818: character maps to <undefined>

(cherry picked from commit e85c860)

pyreadline#56:
This commit and the previous three commits are from
https://github.com/ankostis/pyreadline/tree/redisplay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'readline' has no attribute 'redisplay'
6 participants
@ankostis @musm @skywind3000 @brgirgis @eabase @eric-wieser
0