ensure comparison returns bool instead of np.bool #3333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b1352c to
eb440f5
Compare
|
Following is an MWE that demonstrates the error when upgrading to NumPy 2.3.0 import numpy as np
from PySide6 import QtCore, QtWidgets
class Item(QtWidgets.QTableWidgetItem):
def __init__(self, value):
super().__init__(str(value))
self.value = value
def __lt__(self, other):
return self.value < other.value
data = np.arange(10).reshape((5, 2))
nrows, ncols = data.shape
app = QtWidgets.QApplication([])
wgt = QtWidgets.QTableWidget(nrows, ncols)
for row in range(nrows):
for col in range(ncols):
wgt.setItem(row, col, Item(data[row, col]))
wgt.sortByColumn(0, QtCore.Qt.SortOrder.DescendingOrder)
wgt.show()
app.exec() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.3.0 includes an expired deprecation: numpy/numpy#28254
'np.bool' scalars can no longer be interpreted as an index (deprecated since 1.19)This triggers an error in
pg.TableWidgetwhen a structured array is used, as demonstrated by theTableWidgetexample itself. (https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/examples/TableWidget.py)On PyQt6:
TypeError: invalid result from TableWidgetItem.__lt__(), a 'bool' is expected not 'numpy.bool'On PySide6:
TypeError: 'numpy.bool' object cannot be interpreted as an integer