have mkQApp configure QApplication such that it handles HIDPI displays on Windows #1509
Conversation
984f805 to
b4b11b1
Compare
|
This seems to address the issues with a single monitor; I have the equipment to check w/ multiple monitors with different DPI properties...will try verify against those. |
|
Experimenting w/ this locally; I'm having a tough time getting all the above
Still have more experimentation to make... |
|
🤦♂️ here I'm testing examples, wondering why nothing is behaving different, only to realize when running an example by itself, it spins up it's own |
7a80c05 to
3503a3e
Compare
|
Special thanks for @QuLogic for creating matplotlib/matplotlib#19123 which was the implementation I needed to see to fix #422 |
|
On Qt < 5.14, I would get the In the comments of #756 there was an interesting comment from @Androwei about using |
|
This concept is great! Just wondering: You are not removing old High DPI-fixes there, so this should not change anything on old code, right? Is there any reason for using PyQtGraph without these flags you set there? In any case, it might be a good idea to write this also in the documentation for people that do not rely on mkQApp? |
|
PS: Can't stress it enough - Finally being able to just code for PyQtGraph without worrying about HighDPI screens is a really awesome sight! |
|
Fwiw this only works if you user mkqapp, many applications using pyqtgraph
may instantiate qapplication themselves do the benefits here wouldn't do
anything.
…On Sun, Jan 24, 2021 at 16:29 2xB ***@***.***> wrote:
PS: Can't stress it enough - Finally being able to just code for PyQtGraph
without worrying about HighDPI screens is a really awesome sight!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1509 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE5Z7VWLJFDB426K5LL6VDS3S3MZANCNFSM4WPO7BAQ>
.
|
I'm not aware of any dpi related fixes that were in the library before. Also I'm not opposed to adding something to some documentation, but I'm not sure where it would go. |
|
@j9ac9k You are of course right. I think the great thing is that if this issue is brought up in the future, one can just point people to the documentation or the definition of https://pyqtgraph.readthedocs.io/en/latest/how_to_use.html#embedding-widgets-inside-pyqt-applications could be reasonable? |
|
Oh right! I forgot about the date axis... I'll take a look there. |
|
Regarding the fontScaleFactor bit; I'm unable to "break" it ... but I'm struggling to recall the condition that warranted its usage to begin with: on non-hidpi external display: on hidpi primary display: Looks much the same on Qt6.... I'm going to remove its usage and say it's good... if someone has a hidpi monitor that can verify |
|
@2xB (or anyone else for that matter) ... I'm having trouble getting a link to work in the documentation: In the section I just wrote, I have this line, wanting to link to Problem is that it does not appear that the contents of EDIT: Disregard, figured it out 👍 |
|
Ok, I think this is ready to merge, I think @ksunden said he would try and verify on his hidpi display, I'll give him another day. I think this guy is ready to merge unless there are further suggestions. |
|
Alright, given I haven't heard anyone saying they've had issues, I'll merge, and await the hidpi issues to come in later 😆 |
|
Congratulations, this is fantastic! |
Still need to do some more testing, looks like Qt6 has great support for hidpi on windows from the get-go. On Qt5, you need to set some environment variables, which this PR is meant to address.
Leaving this PR in draft form as it needs more testing.
Also need to verify fractional scaling; for reference here is how fractional scaling was addressed in matplotlib: matplotlib/matplotlib#15656