8000 Make the revision part percent-encoded in version control URLs by kazssym · Pull Request #13407 · pypa/pip · GitHub
[go: up one dir, main page]

Skip to content

Make the revision part percent-encoded in version control URLs #13407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kazssym
Copy link
@kazssym kazssym commented May 28, 2025

This PR changes how the revision specification is handled in version control URLs. When a branch name contains special characters such as '@' or '#', they must be percent-encoded in URLs; however, this is not currently implemented.

Fixes #10226

@kazssym
Copy link
Author
kazssym commented May 28, 2025

Attempting to fix #10226

@kazssym
Copy link
Author
kazssym commented May 28, 2025

We need to add test cases.

@kazssym
Copy link
Author
kazssym commented May 28, 2025

We need to add test cases.

Added.

@kazssym kazssym marked this pull request as ready for review May 28, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3F67
Development

Successfully merging this pull request may close these issues.

pip doesn't properly parse git URL if branch name contains @ or #
1 participant
0