mypy: Fix all union-attr #366
Open
+23
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
May 4, 2025
| @@ -360,7 +360,7 @@ def build_modules(self) -> None: | |||
| self.build_module(module, module_file, package) | |||
|
|
|||
| def build_packages(self) -> None: | |||
| for package in self.packages: | |||
| for package in self.packages or (): | |||
There was a problem hiding this comment.
This is a change in behaviour as it would graciously do nothing instead of raising if self.packages is still None.
If it makes more sense to raise, a clearer error than TypeError: 'NoneType' object is not iterable can be raised instead.
Avasam
commented
May 4, 2025
Comment on lines
+235
to
+237
| _wordchars_re = re.compile(rf'[^\\\'\"{string.whitespace} ]*') | ||
| _squote_re = re.compile(r"'(?:[^'\\]|\\.)*'") | ||
| _dquote_re = re.compile(r'"(?:[^"\\]|\\.)*"') |
There was a problem hiding this comment.
This isn't exactly "heavy computing" is it? Did it need to be done lazily ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.