8000 test python 3.12 by zingale · Pull Request #710 · pynucastro/pynucastro · GitHub
[go: up one dir, main page]

Skip to content

test python 3.12 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2024
Merged

test python 3.12 #710

merged 4 commits into from
Feb 6, 2024

Conversation

zingale
Copy link
Member
@zingale zingale commented Dec 22, 2023

No description provided.

@zingale
Copy link
Member Author
zingale commented Feb 2, 2024

The python 3.12 failures might be from this change in python 3.12?
python/cpython#100426

@zingale
Copy link
Member Author
zingale commented Feb 2, 2024

maybe we should set numpy.set_printoptions() for the precision?

@yut23
Copy link
Collaborator
yut23 commented Feb 2, 2024

I'm not sure if that applies to non-array types, but it's worth a try.

@yut23
Copy link
Collaborator
yut23 commented Feb 5, 2024

The sum() accuracy improvement is indeed the source of the change. I replaced the calls to sum in Composition with math.fsum and reran the notebooks with 3.10, and got the same results as the 3.12 tests here. Should we add that to this PR or make a new one?

@zingale
Copy link
Member Author
zingale commented Feb 5, 2024

let's make a new one and merge that and then do this

@yut23
Copy link
Collaborator
yut23 commented Feb 5, 2024

Needs #720

@zingale zingale merged commit 5033849 into pynucastro:main Feb 6, 2024
@zingale zingale deleted the py312 branch February 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0