8000 Fixes #453. In get_header, check for None in column_names and column_… by kenrobbins · Pull Request #456 · pymssql/pymssql · GitHub
[go: up one dir, main page]
Skip to content

Fixes #453. In get_header, check for None in column_names and column_… #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #453. In get_header, check for None in column_names and column_… #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes #453. In get_header, check for None in column_names and column_… 
…types in addition to checking for 0 num_columns.
  • Loading branch information
Ken Robbins committed Aug 26, 2016
commit 191b4844182dd24a6e9aadb055ed2527a0cb0ee4
3 changes: 3 additions & 0 deletions src/_mssql.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,6 +1220,9 @@ cdef class MSSQLConnection:
if self.num_columns == 0:
log("_mssql.MSSQLConnection.get_header(): num_columns == 0")
return None
elif self.column_names is None or self.column_types is None:
log("_mssql.MSSQLConnection.get_header(): column_names is None or column_types is None")
return None

header_tuple = []
for col in xrange(1, self.num_columns + 1):
Expand Down
0