8000 Contribute section by symeneses · Pull Request #98 · pymc-devs/pymc-data-umbrella · GitHub
[go: up one dir, main page]
Skip to content

Contribute section #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 21, 2022
Merged

Contribute section #98

merged 15 commits into from
Jun 21, 2022

Conversation

symeneses
Copy link
Contributor

It improves the contribute section.

@symeneses symeneses requested review from OriolAbril and reshamas June 21, 2022 10:45
OriolAbril
OriolAbril approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member
@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, other than the pymc donate link, the rest of the comments are styling links I'd be happy either way whether they are used or not.

reshamas
reshamas reviewed Jun 21, 2022
View reviewed changes
reshamas
reshamas reviewed Jun 21, 2022
View reviewed changes
reshamas
reshamas reviewed Jun 21, 2022
View reviewed changes
reshamas
reshamas reviewed Jun 21, 2022
View reviewed changes
reshamas
reshamas reviewed Jun 21, 2022
View reviewed changes
@reshamas
Copy link
Member

@symeneses This looks great! Thanks for adding all the extra ways folks can contribute!.

@reshamas
Copy link
Member

@OriolAbril @symeneses Overall comment here on text for links.

Short story

Do not include links in this format:
[here][https://xxx.xxx.xxx]

Do provide links with descriptive text:

To support Data Umbrella and keep it running, please donate to the [Data Umbrella Collective](https://opencollective.com/data-umbrella)

Longer story

Accessible Hyperlinks - What are They? Who Benefits?
When there are links in a document, screen reader users can pull up a list of links embedded in the document
Descriptive text provides context for all users and people who are: Blind/Low vision

Reference: scikit-learn/scikit-learn#21214 (comment)

symeneses and others added 6 commits June 21, 2022 15:15
@symeneses @OriolAbril
📝 Update url
c7fbcd8 
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
@symeneses
🎨 refer to index
cff14b0
@symeneses
📝 add link to community partners
71e2fd6
@symeneses @reshamas
📝 update translation header
e42c864 
Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com>
@symeneses @reshamas
📝 add instructions for translators
3dfb84f 
Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com>
@symeneses @reshamas
✏️ typo
c53c7b8 
Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com>
OriolAbril
OriolAbril reviewed Jun 21, 2022
View reviewed changes
reshamas
reshamas reviewed Jun 21, 2022
View reviewed changes
symeneses and others added 5 commits June 21, 2022 16:23
@symeneses @OriolAbril
:penci: change twitter icon
499d5f7 
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
@symeneses @reshamas
📝 update donation text
74ec5d2 
Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com>
@symeneses
💄 use material
faf71a7
@symeneses
🔥 remove triaging
aac9e68
@symeneses
📝 update header translating
5896398
@OriolAbril OriolAbril merged commit 46faebf into pymc-devs:main Jun 21, 2022
@symeneses symeneses deleted the contribute branch June 21, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reshamas reshamas reshamas left review comments

@OriolAbril OriolAbril OriolAbril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@symeneses @reshamas @OriolAbril
0