8000 Add new vi plots by aloctavodia · Pull Request #196 · pymc-devs/pymc-bart · GitHub
[go: up one dir, main page]
Skip to content

Add new vi plots #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add new vi plots #196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90da2cd
add new vi plots
aloctavodia Nov 25, 2024
38a11f3
fix tests
aloctavodia Nov 25, 2024
84f0a97
add missing file
aloctavodia Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@aloctavodia
aloctavodia committed Nov 25, 2024
commit 38a11f341b0b7ebe79ad43562461e2daec836424
6 changes: 4 additions & 2 deletions pymc_bart/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
plot_pdp,
plot_scatter_submodels,
plot_variable_importance,
plot_variable_inclusion,
)

__all__ = [
Expand All @@ -32,13 +33,14 @@
"ContinuousSplitRule",
"OneHotSplitRule",
"SubsetSplitRule",
"compute_variable_importance",
"plot_convergence",
"plot_dependence",
"plot_ice",
"plot_pdp",
"plot_variable_importance",
"compute_variable_importance",
"plot_scatter_submodels",
"plot_variable_importance",
"plot_variable_inclusion",
]
__version__ = "0.7.1"

Expand Down
12 changes: 7 additions & 5 deletions pymc_bart/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def _create_figure_axes(
n_plots = len(var_idx) * shape

if ax is None:
axes = _get_axes(grid, n_plots, False, sharey, figsize)
fig, axes = _get_axes(grid, n_plots, False, sharey, figsize)

elif isinstance(ax, np.ndarray):
axes = ax
Expand Down Expand Up @@ -528,7 +528,7 @@ def _get_axes(grid, n_plots, sharex, sharey, figsize):
for i in range(n_plots, len(axes)):
fig.delaxes(axes[i])
axes = axes[:n_plots]
return axes
return fig, axes


def _prepare_plot_data(
Expand Down Expand Up @@ -958,7 +958,7 @@ def compute_variable_importance( # noqa: PLR0915 PLR0912
def plot_variable_importance(
vi_results: dict,
X: npt.NDArray[np.float64],
labels: Optional[List[str]] = None,
labels=None,
figsize=None,
plot_kwargs: Optional[Dict[str, Any]] = None,
ax: Optional[plt.Axes] = None,
Expand Down Expand Up @@ -1016,7 +1016,9 @@ def plot_variable_importance(
_, ax = plt.subplots(1, 1, figsize=figsize)

if labels is None:
labels = list(np.arange(n_vars).astype(str))
labels = np.arange(n_vars).astype(str)
else:
labels = np.asarray(labels)

new_labels = ["+ " + ele if index != 0 else ele for index, ele in enumerate(labels[indices])]

Expand Down Expand Up @@ -1062,7 +1064,7 @@ def plot_scatter_submodels(vi_results, func=None, grid="long", axes=None):
preds_all = vi_results["preds_all"]

if axes is None:
axes = _get_axes(grid, len(indices), False, True, None)
_, axes = _get_axes(grid, len(indices), False, True, None)

func = None
if func is not None:
Expand Down
Loading
0